Azure / Azure/Integration-Services-Landing-Zone-Accelerator

Missing A records for Log Analytics with PE and AMPLS

Open
#41 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Bicep
Stars
68
Forks
51
PR merge metrics
No merged PRs in 30d

Description

Hello,

With the current logging.bicep, no A records are created for the Log Analytics Workspace with private endpoint and AMPLS. This code is needed.

```
// For DNS A records for Azure Monitor with PE and AMPLS.
resource existingStorageAccountPrivateDnsZone 'Microsoft.Network/privateDnsZones@2020-06-01' existing = {
name: storageAccountPrivateDnsZoneName
}
resource existingMonitorPrivateDnsZone 'Microsoft.Network/privateDnsZones@2020-06-01' existing = {
name: monitorPrivateDnsZoneName
}
resource existingOmsPrivateDnsZone 'Microsoft.Network/privateDnsZones@2020-06-01' existing = {
name: omsPrivateDnsZoneName
}
resource existingOdsPrivateDnsZone 'Microsoft.Network/privateDnsZones@2020-06-01' existing = {
name: odsPrivateDnsZoneName
}
resource existingAgentSvcPrivateDnsZone 'Microsoft.Network/privateDnsZones@2020-06-01' existing = {
name: agentSvcPrivateDnsZoneName
}

param storageAccountPrivateDnsZoneName string
param monitorPrivateDnsZoneName string
param omsPrivateDnsZoneName string
param odsPrivateDnsZoneName string
param agentSvcPrivateDnsZoneName string

resource privateEndpointDnsGroup 'Microsoft.Network/privateEndpoints/privateDnsZoneGroups@2022-09-01' = if(usePrivateEndpoint){
parent: privateLinkScopePrivateEndpoint
name: 'privateDnsZoneGroup'
properties: {
privateDnsZoneConfigs: [
{
name: replace(monitorPrivateDnsZoneName,'.','-')
properties: {
privateDnsZoneId: existingMonitorPrivateDnsZone.id
}
}
{
name: replace(omsPrivateDnsZoneName,'.','-')
properties: {
privateDnsZoneId: existingOmsPrivateDnsZone.id
}
}
{
name: replace(odsPrivateDnsZoneName,'.','-')
properties: {
privateDnsZoneId: existingOdsPrivateDnsZone.id
}
}
{
name: replace(agentSvcPrivateDnsZoneName,'.','-')
properties: {
privateDnsZoneId: existingAgentSvcPrivateDnsZone.id
}
}
{
name: replace(storageAccountPrivateDnsZoneName,'.','-')
properties: {
privateDnsZoneId: existingStorageAccountPrivateDnsZone.id
}
}
]
}
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.