Azure / Azure/DotNetty

Endless loop in CombinedEnumerator.MoveNext()

Open
#623 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
4.3k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

We have forever loop in `DotNetty.Transport.Channels.Groups.CombinedEnumerator.MoveNext()` because in .NET 8
an empty `ReadOnlyCollection` returns a singleton empty enumerator (https://github.com/dotnet/runtime/pull/76097).

So there could be two identical enumerators here:
https://github.com/Azure/DotNetty/blob/78c5757062a9eb62e2aab2bbb35d3983710f9651/src/DotNetty.Transport/Channels/Groups/CombinedEnumerator.cs#L12-L13

Which leads to an endless loop here:
https://github.com/Azure/DotNetty/blob/78c5757062a9eb62e2aab2bbb35d3983710f9651/src/DotNetty.Transport/Channels/Groups/CombinedEnumerator.cs#L33-L47

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.