Azure / Azure/Azure-Spring-Apps

Automatically change ContainerProbeSettings to true when using custom probes

Open
#57 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
9
Forks
11
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**

Yes, this feature request is related to a report that is already closed https://github.com/Azure/Azure-Spring-Apps/issues/15 and support ticket.

**Describe the solution you'd like**

It will be good when switching from default `ContainerProbeSettings.disableProbe = FALSE` to custom readiness and liveness probe settings that ASA automatically change `ContainerProbeSettings.disableProbe` to `TRUE`. This way customers can avoid the error message:

```
There was a problem saving the configuration. Custom Probe feature cannot be used with ContainerProbeSettings together..
```

**Describe alternatives you've considered**

This solution can be applied for IaC scripts like ARM/Bicep/Terraform and Azure CLI.

**Describe the Customer Impact**

Customers have to redeploy all their app deployments that are already using `ContainerProbeSettings` which is a tedious work that have to be done and may cause delay in their deadlines.

**Additional context**

Add any other context or screenshots about the feature request here.

**Can we contact you for additional details?** Y/N

If yes, please send us your contact information to AzureSpringCloud-Talk@service.microsoft.com and include the issue number in the email title.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.