Azure / Azure/Azure-Landing-Zones

Missing Privatelinks for the Deploy-Private-DNS-Zones policy

Open
#461 2 comments 8 reactions 0 assignees View on GitHub
Transfer From: caf-enterprise-scale :arrow_right:
Dominant language
PowerShell
Stars
96
Forks
70
Avg merge
3d 1h
Merged PRs (30d)
7

Description

### Community Note

- Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request
- Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
- If you are interested in working on this issue or have submitted a pull request, please leave a comment

### Description

#### Is your feature request related to a problem?

We are using only the default CAF Policy for Private Endpoints Zone deployments but it seems there are lot of Privatelink policies are missing the set definition [Deploy-Private-DNS-Zones](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/blob/main/modules/archetypes/lib/policy_set_definitions/policy_set_definition_es_deploy_private_dns_zones.tmpl.json)

#### Describe the solution you'd like

Request to add all the missing private endpoint dns Zone to the set definition.
"privatelink.azure-api.net",
"privatelink.database.windows.net",
"privatelink.mariadb.database.azure.com",
"privatelink.mysql.database.azure.com",
"privatelink.postgres.database.azure.com",
"privatelink.azurehealthcareapis.com",
"privatelink.azurestaticapps.net",
"privatelink.dicom.azurehealthcareapis.com",
"privatelink.guestconfiguration.azure.com",
"privatelink.digitaltwins.azure.net",
"privatelink.managedhsm.azure.net",
"privatelink.pbidedicated.windows.net",
"privatelink.purview.azure.com",
"privatelink.purviewstudio.azure.com",
"privatelink.redisenterprise.cache.azure.net",
"privatelink.tip1.powerquery.microsoft.com",
"privatelink.token.botframework.com"

#### Additional context

Contributor guide

Open the contributing guide

Research direction

Open modules/archetypes/lib/policy_set_definitions/policy_set_definition_es_deploy_private_dns_zones.tmpl.json in terraform-azurerm-caf-enterprise-scale and compare its entries with the requested private DNS zones. Done means the missing zones are represented in the Deploy-Private-DNS-Zones set definition and the resulting list is reviewed for completeness.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, terraform
Domain
cloud, infrastructure
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.