Azure / Azure/Azure-Landing-Zones
When logging in to ADO with the secondary approver, the new ADO project doesn't appear.
- Dominant language
- PowerShell
- Stars
- 97
- Forks
- 70
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 7
Description
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Infrastructure as Code Type? (Required)
terraform
### PowerShell Module Version (Optional)
4.2.2
### Bootstrap Module Version (Optional)
4.7.5
### Starter Module? (Required)
terraform - platform_landing_zone
### Starter Module Version (Optional)
~>1.7
### Input arguments of the ALZ-PowerShell-Module (Optional)
---
# For detailed instructions on using this file, visit:
# https://aka.ms/alz/accelerator/docs
# Basic Inputs
iac_type: "terraform"
bootstrap_module_name: "alz_azuredevops"
starter_module_name: "platform_landing_zone"
# Shared Interface Inputs
bootstrap_location: "eastus2"
starter_locations: ["eastus2", "centralus"]
root_parent_management_group_id: ""
subscription_id_management: ""
subscription_id_identity: ""
subscription_id_connectivity: ""
# Bootstrap Inputs
azure_devops_personal_access_token: ""
azure_devops_agents_personal_access_token: ""
azure_devops_organization_name: "autocloudarc-mcaps"
use_separate_repository_for_templates: true
bootstrap_subscription_id: ""
service_name: "ref"
environment_name: "mgmt"
postfix_number: 1
azure_devops_use_organisation_legacy_url: false
azure_devops_create_project: true
azure_devops_project_name: "lza-tfm-ado-01"
use_self_hosted_agents: true
use_private_networking: true
allow_storage_access_from_my_ip: true
apply_approvers: ["admin@","devia.delta@"]
create_branch_policies: true
# Advanced Inputs
bootstrap_module_version: "latest"
starter_module_version: "latest"
#output_folder_path: "/accelerator/output"
### Debug Output/Panic Output (Optional)
```shell
```
### Expected Behaviour (Required)
When logging into ADO to approve the plan pipeline as the secondary user - **devia.delta@tenant-fqdn-suffix**, I expected to see the **lza-tfm-ado-01** project within my **autocloudarc-mcaps** organization.
### Actual Behaviour (Required)
Instead, I did not see the *lza-tfm-ado-01** project, as if the **[lza-tfm-ado-01]/ref-mgmt-approvers** by virtue of being a member of the **Project Valid Users** does not grant sufficient permissions to see the project in order to then select and approve the plan environment stage.
As a workaround, in ADO, while logged in as the primary user and project administrator, I had to add this approvers group **ref-mgmt-approvers** to the default project team as well: **[lza-tfm-ado-01]/lza-tfm-ado-01 Team**. Only then was I able to log in as the secondary user and proceed with the required approver.
### Steps to Reproduce (Optional)
1. After the bootstrap Cmdlet completes...
2. Log into the ADO org as the primary approver / project administrator.
3. Initiate the **02 Azure Landing Zones Continuous Delivery** pipeline.
4. Log into ADO org (preferably in a private browser session) with the secondary approver.
5. Locate the project containing the pipeline - stuck here because (for me) it doesn't appear.
### Important Factoids (Optional)
Here is the screenshot of now logging in with the secondary approver after the approvers group was added to the default project administrators group, which is the workaround.
### References (Optional)
NA
Contributor guide
Research direction
Start by reproducing the bootstrap Cmdlet flow with the listed Terraform starter and bootstrap module versions, then inspect how the ref-mgmt-approvers group is assigned to the ADO project and pipeline approval environment. Done means the secondary approver can see lza-tfm-ado-01 and approve the plan stage without manually adding the group to the default project team.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, powershell, terraform
- Domain
- authorization, cloud, devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100