Azure-Samples / Azure-Samples/tutor

[P2] ci-cd: guardrail does not validate required APIM CORS origins

Open
#137 0 comments 0 reactions 0 assignees View on GitHub
component:ci-cd priority:P2 type:regression type:tech-debt
Dominant language
Python
Stars
17
Forks
8
PR merge metrics
No merged PRs in 30d

Description

## Problem
Current post-deploy guardrail in azd-deploy validates only presence of block, not required environment origins.

## Why this matters
CI can pass while APIM CORS policy is still missing the live SWA origin, causing real browser failures after successful deploy/provision runs.

## Evidence
- azd-deploy run succeeded previously while CORS error persisted in browser.
- Live policy for configuration-api had but only localhost origins.

## Reproduction
1. Deploy infra/workflows successfully.
2. Keep APIM policy with localhost-only origins and no SWA origin.
3. Observe workflow guardrails pass but browser requests fail due CORS.

## Impact
- User impact: High (false-positive green pipeline).
- Blast radius: CI/CD reliability and release confidence.

## Acceptance Criteria
- [ ] Guardrail explicitly checks required origins list, including active SWA default hostname and configured custom domains.
- [ ] Guardrail fails with clear diff (missing origins).
- [ ] Non-prod remediation step can apply/update APIM per-service policy when origins drift.
- [ ] Add test coverage or workflow assertion for origin completeness.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.