Azure-Samples / Azure-Samples/ms-identity-docs-code-dotnet
Peg package versions in project files
- Dominant language
- C#
- Stars
- 65
- Forks
- 52
- PR merge metrics
- No merged PRs in 30d
Description
@OwenRichards1 ... Hello! I was checking some cross-links in the ASP.NET Core docs, and I noticed that several Azure samples (in different repos) are floating versions against our best practices guidelines ...
https://github.com/search?q=repo%3AAzure-Samples%2Fms-identity-docs-code-dotnet+%22.*\%22%22&type=code
One of them ... the one that I was checking a cross-link on ... is one that you performed an upgrade on ...
https://github.com/Azure-Samples/ms-identity-docs-code-dotnet/blob/main/spa-blazor-wasm/BlazorWasm.csproj
Would you (or someone) mind pegging the package refs to "`8.0.0`." I realize that there's no 8.1 (and likely never going to be one) and that floating will just roll-forward the patch release. However, patches roll forward automatically anyway, and we (on the ASP.NET Core engineering side) don't recommend showing devs samples that adopt the practice of floating versions due to stability/security concerns. We consider it a dangerous habit to form.
In addition to that sample, we'd like to get the others updated as well to patch to their floating package versions. They lie across different repos, and I'm not sure if one person can update all four of them based on this one issue or if three more issues should be opened (one on each of the other three sample repos).
Contributor guide
Research direction
Start with spa-blazor-wasm/BlazorWasm.csproj and inspect the package references that currently use floating versions. Search the repository for other floating package references in project files, then pin the requested references to 8.0.0 and verify that the affected samples still restore or build successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100