Azure-Samples / Azure-Samples/ms-identity-ciam-dotnet-tutorial
Why does the sign-in-maui MSALClientHelper.cs have a reference to Microsoft.Identity.Client.Desktop?
- Dominant language
- PowerShell
- Stars
- 48
- Forks
- 35
- PR merge metrics
- No merged PRs in 30d
Description
### This issue is for a: (mark with an `x`)
```
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)
```
### Minimal steps to reproduce
> Follow the instructions from [Tutorial: Create a .NET MAUI shell app](https://learn.microsoft.com/en-us/entra/external-id/customers/tutorial-mobile-app-maui-sign-in-prepare-app#add-msal-sdk-support-using-msal-helper-classes)
### Any log messages given by the failure
> After referencing the `Microsoft.Identity.Client.Desktop` package needed in [MSALClientHelper.cs](https://github.com/Azure-Samples/ms-identity-ciam-dotnet-tutorial/blob/main/1-Authentication/2-sign-in-maui/MSALClient/MSALClientHelper.cs) the MAUI app will not build and shows a [NETSDK1136: The target framework must be Windows](https://learn.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1136) error.
### Expected/desired behavior
> After following the tutorial as written, the code builds.
### OS and Version?
> Windows 10
### Versions
>
### Mention any other details that might be useful
> I created a git repo that just follows the instructions from the tutorial. The commits should tell the story (https://github.com/scottpantall/sign-in-maui/commits/master/).
>The only reason for the `Microsoft.Identity.Client.Desktop` package in [MSALClientHelper.cs](https://github.com/Azure-Samples/ms-identity-ciam-dotnet-tutorial/blob/main/1-Authentication/2-sign-in-maui/MSALClient/MSALClientHelper.cs) is to use the `WithWindowsEmbeddedBrowserSupport()` extension method which [documentation says is unnecessary for MAUI applications](https://learn.microsoft.com/en-us/dotnet/api/microsoft.identity.client.desktop.desktopextensions.withwindowsembeddedbrowsersupport?view=msal-dotnet-latest#remarks). When I removed this reference I was able to build my MAUI application.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.