Azure-Samples / Azure-Samples/communication-services-javascript-quickstarts

Typo in CallAutomation_OutboundCalling/src/app.ts

Open
#317 0 comments 0 reactions 0 assignees View on GitHub
status:triage
Dominant language
JavaScript
Stars
108
Forks
207
PR merge metrics
No merged PRs in 30d

Description

> Please provide us with the following information:
> ---------------------------------------------------------------

### This issue is for a: (mark with an `x`)
```
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)
```

### Minimal steps to reproduce
>Purposely make a TextSource / FileSource / SsmlSource fail to reporduce.

### Any log messages given by the failure
>
Call back event received, callConnectionId=xxxx-xxxx-xxxx, serverCallId=yyyyyyyyyy, eventType=Microsoft.Communication.**PlayFailed**

### Expected/desired behavior
>The call should be terminated.

### OS and Version?
> Node.js running on Windows

### Versions
> Commit d46e964 (latest when opening this issue)

### Mention any other details that might be useful
Hello, I'd like to report a type error in line 161 of the file CallAutomation_OutboundCalling/src/app.ts, the event checked should be "Microsoft.Communication.**P**layFailed" but it's "Microsoft.Communication.**p**layFailed".
This causes the call to not be terminated in case of a failure while playing the message.
> ---------------------------------------------------------------
> Thanks! We'll be in touch soon.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.