Azure-Samples / Azure-Samples/azure-openai-rag-workshop-java

Conflicting ChatRequest name

Open
#20 4 comments 0 reactions 1 assignee Claimed by @agoncal View on GitHub
Dominant language
Bicep
Stars
21
Forks
102
Avg merge
3d 14h
Merged PRs (30d)
1

Description

In the workshop there is a `ChatRequest` class. But in the last LC4j versions there is now an experimental `ChatRequest` API too. And if you leave your IDE doing the auto-import, it imports the LC4j one. We should change the name of the API (and also the `ChatResource`....). Maybe `ChatRagRequest` or something like that

https://github.com/langchain4j/langchain4j/blob/main/langchain4j-core/src/main/java/dev/langchain4j/model/chat/request/ChatRequest.java

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.