Azure-Samples / Azure-Samples/azure-openai-assistant-javascript

Standarization accepatance criteria

Open
#6 0 comments 0 reactions 2 assignees Claimed by @gkulin View on GitHub
msstandarization
Dominant language
Bicep
Stars
44
Forks
49
Avg merge
5d 22h
Merged PRs (30d)
1

Description

The following checklist must be complete before a template is published.

# Repository Management

- [x] Standards compliant [README.md](https://github.com/Azure-Samples/azd-template-artifacts/blob/main/README.md) as the one in the example, is in place
- [x] [License](https://github.com/Azure-Samples/azd-template-artifacts/blob/main/LICENSE.md) is in place. Make sure you choose the [correct license](https://www.microsoft.com/en-us/legal/intellectualproperty/open-source)
- [x] [Security guidelines](https://github.com/Azure-Samples/azd-template-artifacts/blob/main/SECURITY.md) are in place
- [x] [Contribution guidelines](https://github.com/Azure-Samples/azd-template-artifacts/blob/main/CONTRIBUTING.md) are in place
- [x] [Code of conduct](https://github.com/Azure-Samples/azd-template-artifacts/blob/main/.github/CODE_OF_CONDUCT.md) is in place
- [x] [Issue template](.github/ISSUE_TEMPLATE.md) is in place
- [x] Language, model, and relevant technology topic labels are added, including `azd-templates` and `ai-azd-templates` (The latter is being created)
- [x] Repo description is in place, describing the use case and technologies used in the solution

## Source code structure and conventions

- [x] GitHub Actions (This refers to .github/workflows/azure-dev.yml or custom workflow to run on a GitHub runner) is in place
- [x] DevContainer (/.devcontainer folder where applicable) configuration is in place
- [x] Infrastructure as code is in place (`/infra` folder where applicable, manifest files or code generators in the case of `Aspire` and similar )
- [x] Azure services configuration (/azure.yml file) is in place
- [x] Minimum coverage tests are in place

## Functional requirements

- [x] `azd up` successfully provisions and deploys a functional app
- [x] GitHub Actions run tasks without errors
- [x] DevContainer has been tested locally and runs
- [x] Codespaces run [locally and in browser]
- [x] All tests pass

In the absence of e2e tests,

- [x] The application has been manually tested to work as per the requirement

## Security requirements

- [x] Microsoft Managed Identity is implemented
- [x] [microsoft/security-devops-action](https://github.com/microsoft/security-devops-action) is integrated to the CI/CD pipeline and the analyzer were ran

When a service selected doesn't support Managed Identity, the corresponding issue must have been reported and the security considerations section in the readme, should clearly explain the alternatives.

- Azure Key Vault is a preferred alternative

### The following items are not strictly enforced but may prevent the template from being added to the gallery.

Project code follows standard structure, [per language](https://github.com/Azure-Samples/azd-template-artifacts/tree/main/docs/structure-samples). Please check one.

- [x] Yes, follows standards
- [ ] No, doesn't follow standards

Code follows recommended style guide

- [x] Yes, follows style guide
- [ ] No, doesn't follow style guide

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.