Azure-Samples / Azure-Samples/azure-files-samples

Incorrect exception handling

Open
#87 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PowerShell
Stars
261
Forks
202
Avg merge
1d 5h
Merged PRs (30d)
4

Description

The try / catch block for `# Create the identity in Active Directory` on line 2543 asserts that it exists to `Give better error message when AD exception is thrown for invalid SAMAccountName length.` However, it also catches the exception which is thrown when `AllowReversiblePasswordEncryption` is not in AD Schema / attribute doesn't exist on computer object.

We needed to remove lines 2579 and 2589 for the module to work in our environment.

Edit: To clarify, this is for azure-files-samples/AzFilesHybrid/AzFilesHybrid.psm1

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.