Azure-Samples / Azure-Samples/app-service-javascript-sap-cap-quickstart

Recommend updating appservice.bicep to latest azure-dev files

Open
#36 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Bicep
Stars
14
Forks
32
Avg merge
3d 15h
Merged PRs (30d)
1

Description

In the original version of appservice.bicep, appSettings was not wrapped with an @secure decorator, so if a developer put any secrets in their app settings, it would leak into deployment outputs and cause a security alert. The latest version now has the secure decorator.

I noticed this repo is using the old version, so I recommend upgrading if you can.

You can git clone https://github.com/azure/azure-dev and then cp like this:

cp ../azure-dev/templates/common/infra/bicep/core/host/* infra/core/host/.

Or only cp app service files if you don't use other hosts:

cp ../azure-dev/templates/common/infra/bicep/core/host/appservice* infra/core/host/.

Then run azd up to make sure all still works.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.