Azure-Samples / Azure-Samples/active-directory-dotnet-native-aspnetcore-v2

Make sure the PoP handler is capable of validating the 'b' claim

Open
#131 0 comments 0 reactions 1 assignee Claimed by @mafurman View on GitHub
enhancement P2
Dominant language
C#
Stars
290
Forks
194
PR merge metrics
No merged PRs in 30d

Description

> Please provide us with the following information:
> ---------------------------------------------------------------

### This issue is for a: (mark with an `x`)
```
- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)
```

### Minimal steps to reproduce
> The signed http request sent in the PoP sample does not have a 'b' (body) claim, so this claim isn't checked during the validation process.

### Expected/desired behavior
> We need to make sure that the body extracted by the handler can be properly validated.

### Mention any other details that might be useful
> We also want to make sure we are using an appropriately sized buffer when reading in the body of the request inside the handler.
NOTE: Validation of the 'b' claim is optional and should not be added to the sample, but we should confirm that it works.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.