Automattic / Automattic/wp-openid-connect-server
login_header function's second parameter should be string and not null
Open
- Dominant language
- PHP
- Stars
- 44
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
`AuthenticateHandler.php` 55th line:
`login_header( 'OIDC Connect', null, new \WP_Error( 'OIDC_NO_PERMISSION', __( "You don't have permission to use OpenID Connect.", 'openid-connect-server' ) ) );`
should be:
`login_header( 'OIDC Connect', '', new \WP_Error( 'OIDC_NO_PERMISSION', __( "You don't have permission to use OpenID Connect.", 'openid-connect-server' ) ) );`
Contributor guide
Research direction
Open AuthenticateHandler.php at line 55 and inspect the login_header call shown in the issue. Change only the second argument from null to an empty string, then confirm the call matches the requested form.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100