Automattic / Automattic/wp-calypso
[Bug]: Marketplace installs where site has plugin slug with special chars
- Dominant language
- TypeScript
- Stars
- 12.6k
- Forks
- 2k
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 531
Description
### Quick summary
Installing software from the marketplace skips all plugins except direct dependencies when executing the symlink command. Plugins which have en-dashes (\u2013 –) in their slugs will cause a spurious alert to be logged, and investigated.
Other special characters haven't been tested.
### Steps to reproduce
1. Get a Pro/Business/eCommerce site
2. Install a plugin with an en-dash in its slug, e.g. GraphinaPro – Elementor Dynamic Charts & Datatable-v1.3.2
3. Purchase and install a marketplace plugin
### What you expected to happen
The plugin should be installed without error
### What actually happened
The plugin was installed but an installation alert was created saying 'Error: '\u2013' is not a registered wp command. See 'wp help' for available commands.' See p1657961447527469-slack-CJS75TX3R
### Browser
_No response_
### Context
_No response_
### Platform (Simple, Atomic, or both?)
Atomic
### Other notes
_No response_
### Reproducibility
Consistent
### Severity
_No response_
### Available workarounds?
There is no user impact
### Workaround details
This just causes an unnecessary alert for developers to check, there's no visible user impact.
Contributor guide
Research direction
Start by tracing the marketplace installation flow and the symlink command used after installing a plugin, then reproduce it with the GraphinaPro plugin slug containing an en-dash. The work is done when that slug installs without producing the spurious “is not a registered wp command” alert; other special characters are not covered by this report.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100