Automattic / Automattic/wp-calypso

Theme Showcase: Upsell nudge sometimes errors for non-Business Atomic

Open
#55,596 2 comments 0 reactions 0 assignees View on GitHub
[Feature] Theme Showcase [Pri] Low Atomic Upgrade Flows Bug Upsell Nudge
Dominant language
TypeScript
Stars
12.6k
Forks
2k
Avg merge
1d 17h
Merged PRs (30d)
538

Description

Screen Shot 2021-08-18 at 4 14 11 PM

**To reproduce:**

* Switch to a site with no Business plan, but still on Atomic (*.wpcomstaging.com URL)
* Go to `/themes`
* Note the upsell above the Showcase and click on it
* You'll be brought to checkout, where hopefully you have the Business plan in your cart (good, because you shouldn't be able to get any other plan with this type of site :))
* ...but you might get a compatibility error instead:

Screen Shot 2021-08-18 at 4 16 19 PM

Ideally we shouldn't show this upgrade if it's not able to be added to the cart. It's pointing to:

`/checkout/[site].wpcomstaging.com/jetpack_security_realtime`

I think the Jetpack security plan is incompatible because it's technically a free site, even though it's still using Atomic servers.

_Originally posted by @sixhours in https://github.com/Automattic/wp-calypso/issues/38807#issuecomment-901402588_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the flow from `/themes` on a non-Business Atomic site, then trace the upsell link to `/checkout/[site].wpcomstaging.com/jetpack_security_realtime` and inspect the compatibility handling. Done means the incompatible upgrade is not shown, or it no longer sends the user to a checkout error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, payments
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.