Automattic / Automattic/wp-calypso

WhatsApp Button Block: Icon & text overlapping for RTL language

Open
#53,376 5 comments 0 reactions 0 assignees View on GitHub
[Status] Stale Blocks WordPress.com
Dominant language
TypeScript
Stars
12.6k
Forks
2k
Avg merge
1d 17h
Merged PRs (30d)
552

Description

### Steps to reproduce the behavior

1. Go to **My site > Settings > General**
2. Change site language to an RTL one, like Hebrew for example
3. Create a new page or post and add the **WhatsApp Button Block**
4. Check the preview on the live site

#### What I expected to happen

The icons and text should not overlap, as it does for LTR languages (English for example).

![Markup on 2021-06-03 at 18:52:05](https://user-images.githubusercontent.com/29238672/120651846-d573a400-c49c-11eb-824e-9b7d4bbecbfe.png)

#### What actually happened

On RTL languages, like Hebrew, the icon and text overlaps.

![Markup on 2021-06-03 at 18:53:26](https://user-images.githubusercontent.com/29238672/120652039-ffc56180-c49c-11eb-8622-a229f442be26.png)

### Context

This was reported by a user who has set the site language to Hebrew: 29903005-hc

#### Browser / OS version

* Browsers: Chrome, Firefox & Vivaldi
* OS: Mac OS 11.3

#### Does this happen on simple or atomic sites or both?

Both.

#### Is there any console output or error text?

None.

#### Level of impact (Does it block purchases? Does it affect more than just one site?)

Does not block purchases, but affects all sites (simple/atomic).

#### Reproducibility (Consistent, Intermittent) Leave empty for consistent.

#### Screenshot / Video: If applicable, add screenshots to help explain your problem.

Same as above.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue through My site > Settings > General with Hebrew, then add a WhatsApp Button Block and inspect its live-site preview. Locate the WhatsApp Button Block implementation and its RTL-related styling; done means the icon and text no longer overlap in RTL and still render correctly in LTR.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, react, typescript
Domain
frontend, internationalization, localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.