Automattic / Automattic/wp-calypso

i18n-calypso: Remove obsolete `componentUpdateHooks`

Open
#45,697 3 comments 0 reactions 1 assignee Claimed by @yuliyan View on GitHub
Enhancement i18n Packages
Dominant language
TypeScript
Stars
12.6k
Forks
2k
Avg merge
1d 17h
Merged PRs (30d)
538

Description

[componentUpdateHooks](https://github.com/Automattic/wp-calypso/blob/master/packages/i18n-calypso/src/i18n.js#L156) is not being used anywhere in the package besides in the method that pushes items into it - [registerComponentUpdateHook](https://github.com/Automattic/wp-calypso/blob/master/packages/i18n-calypso/src/i18n.js#L418-L420). Therefore, it should be safe to remove it without losing any functionality.

However, since `registerComponentUpdateHook` is being used in a few places in Calypso ([#1](https://github.com/Automattic/wp-calypso/blob/4537033c6794449ce0a10b69d72daf5fa658d553/client/components/community-translator/index.jsx#L41), [#2](https://github.com/Automattic/wp-calypso/blob/31ea12c6617e6298a96402fbc3b0269381de4e8c/client/lib/translator-jumpstart/index.js#L310-L314)), it should be removed from there before removing it from the package.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.