Automattic / Automattic/twenty-nineteen-amp-prototype
AMP validation error regarding CSS with i-amphtml-* class selectors
- Dominant language
- CSS
- Stars
- 2
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
I noticed the AMP validator complaining with:
> The text inside tag 'style amp-custom' contains 'CSS i-amphtml- name prefix', which is disallowed.
This is due these rules:
https://github.com/Automattic/twenty-nineteen-amp-prototype/blob/fe8c1cd6665f2b4701fb44e1cce59bed5810d740/sass/navigation/_menu-main-navigation.scss#L639-L653
I suggest replacing `[class*="i-amphtml-accordion-header"]` with `amp-accordion > section > h2`
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with sass/navigation/_menu-main-navigation.scss at lines 639-653 and inspect the selectors using the i-amphtml- prefix. Replace the affected selector as suggested, then run the AMP validator against the generated CSS to confirm the validation error is gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, sass
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100