Automattic / Automattic/stream-builder

PHP 8.4 Deprecation warning for the CappedPostRanker

Open
#41 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
142
Forks
9
PR merge metrics
No merged PRs in 30d

Description

When updating StreamBuilder on WordPress.com to `0.12.1`, I got the following PHP 8.4 deprecation warning:

```
Deprecated: Tumblr\StreamBuilder\StreamRankers\CappedPostRanker::__construct(): Optional parameter $debug declared before required parameter $panel_allow_ranking is implicitly treated as a required parameter in wp-content/lib/stream-builder/sun/vendor/automattic/stream-builder/lib/Tumblr/StreamBuilder/StreamRankers/CappedPostRanker.php on line 70
```

185493-ghe-Automattic/wpcom

It's not an error deprecation yet so there's time to fix it but I'm not sure what the implications are for breaking compatibility on the constructor for the `CappedPostRanker`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.