Automattic / Automattic/slush-theme-pattern-library
Sass files shouldn't be listed in types when in a type
- Dominant language
- PHP
- Stars
- 11
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
I created a blog traditional type and it's included all the types in the Sass files. It's also put them in under the following structure:
https://cldup.com/jVx2W9dTxo.png
What would be ideal, would be to have if it's a component go under there. Otherwise it should use that types version of the Sass file - not the base one.
So in the case of blog traditional _content.scss would be replaced with the one in that type and also variables/_structure.scss.
Contributor guide
Research direction
Start by tracing how the generator assembles Sass files for the “blog traditional” type. Compare _content.scss and variables/_structure.scss with the base versions and the component placement shown in the issue screenshot. Done means type-specific files replace base files where appropriate and component files are not listed at the type level.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- sass
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100