Automattic / Automattic/simplenote-macos

`Unsynced notes` alert should be dismissed/updated if the connection was restored.

Open
#954 0 comments 0 reactions 0 assignees View on GitHub
[priority] low enhancement
Dominant language
Swift
Stars
1.6k
Forks
172
Avg merge
11h 17m
Merged PRs (30d)
3

Description

[Same for iOS.](https://github.com/Automattic/simplenote-ios/issues/1254)

### Nice to have
If the user sees `Unsynced notes` alert, but the connection was restored and notes were synced, the alert should be updated/replaced with the other one saying that all notes were synced, and it's safe to log out now / cancel. This is so in Electron.

### Why
If the user taps Delete Notes (while notes are already synced, but the user doesn’t know this) the app just logs out. While having only the phone, it’s not clear if the note was deleted or not, and if the connection was restored or not. (in reality, the notes do not get deleted and the user logs out).

Screenshot 2021-04-22 at 19 02 41

Contributor guide

Open the contributing guide

Research direction

Start by locating the macOS code that presents the `Unsynced notes` alert and handles restored connectivity, then compare the expected behavior with the linked iOS issue and the Electron implementation mentioned here. Done means the alert changes to the safe-to-log-out state after notes finish syncing, so Delete Notes no longer leaves the user uncertain.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.