Automattic / Automattic/simplenote-macos

[Fullscreen] App should exit fullscreen on logout

Open
#908 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Swift
Stars
1.6k
Forks
172
Avg merge
11h 17m
Merged PRs (30d)
3

Description

### What
If full screen is active, and the user logs out, the app should exit full screen.

### Why
Current behaviour for non-screen mode is: user logs out, sees the login screen. If the login screen is closed by the user, the app process is still running, and the **login screen can be brought back by clicking the dock icon**.

^ The part described in bold will not work if the app was in full screen before log out:

https://user-images.githubusercontent.com/73365754/110345013-ca90ab00-8036-11eb-956e-ec6ea52772e3.mov

Contributor guide

Open the contributing guide

Research direction

No files or tests are named. Reproduce the issue by entering fullscreen, logging out, closing the login screen, and trying to bring it back from the dock; trace the logout and fullscreen behavior. Done means logout leaves fullscreen and the login screen can be restored from the dock as in non-fullscreen mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
authentication, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.