Automattic / Automattic/simplenote-macos

Dashes and list elements are deleted even with Markdown off

Open
#818 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Swift
Stars
1.6k
Forks
172
Avg merge
11h 17m
Merged PRs (30d)
3

Description

It looks like we delete list-starting elements like `-` and `*` whenever the Enter key is pressed and no matter if Markdown is on or off. This can cause some confusion and resulted on a user report.

### Expected
To be able to add a series of empty elements just like I can with the web app:

```
-
-
-
```

On GitHub, for example, we only remove empty list elements (`-` or `*`) if they are followed by an empty space and the `enter` button.

### Observed

We remove `-` and `*` elements even when Markdown is off:

https://user-images.githubusercontent.com/1136160/105849470-335c2080-5fbf-11eb-9da0-495c69ce1f51.mov

### Reproduced

1. Open a note
2. Make sure that Markdown is off
3. Add `-` or `*`
4. Hit `Enter`

User report: 3655526-zen

Make|Model|macOS Version|App Version
-|-|-|-
Mac|MBP 13|Catalina 10.15.7|2.5

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue by opening a note with Markdown off, entering `-` or `*`, and pressing Enter. Compare the behavior with Markdown enabled and with the expected repeated empty elements; done means list markers are not removed when Markdown is off, while the documented empty-list behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.