Automattic / Automattic/simplenote-macos
[Tags] Possible to have a note with not existing / empty tag
- Dominant language
- Swift
- Stars
- 1.6k
- Forks
- 172
- Avg merge
- 11h 17m
- Merged PRs (30d)
- 3
Description
### Expected
There should be no empty tags.
There should be no cases when app has no tags, but tag is displayed in a note
### Observed
When note having a tag is restored from trash, it will contain a tag, no matter if this tag is present in the app or not.
### Reproduced
1. Create a new note with any text
2. Place a new tag inside the note
3. Trash this note
4. Delete the new tag from tags drawer
5. Restore the note from trash ~> it will have the tag, however the tags drawer will be empty.

This tag in electron will look as an empty tag:

Make|Model|macOS Version|App Version
-|-|-|-
Mac|MBP 15"|10.15.7|2.6
Contributor guide
Research direction
No file or test is named. First reproduce the restore-from-trash flow with a note containing a tag, then inspect the note and tag restoration path; done means restoring a note after its tag is deleted does not leave an empty or nonexistent tag attached while the tags drawer is empty.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100