Automattic / Automattic/simplenote-macos

Rendering freaks out when adding underscore to text

Open
#693 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Swift
Stars
1.6k
Forks
172
Avg merge
11h 17m
Merged PRs (30d)
3

Description

### Reproduced
1. Create new note, Markdown is on by default.
2. Enter the following:

> `* ([Apple](https://books.apple.com)) _about how it was to work at Apple during the original development of Safari and later the iPhone, the internal social and technical processes`

3. Add an underscore `_` to the end. And observe rendering freak out.

### Observed

| Step 2 | Step 3
|--|--
| ![add-s2](https://user-images.githubusercontent.com/156867/95698381-aa042680-0c39-11eb-83ff-f9d478ea45ae.png) | ![add-s3](https://user-images.githubusercontent.com/156867/95698380-aa042680-0c39-11eb-8a88-cfa7280d31df.png)

Then, switch to another note and switch back. The renderer is now normal and with italic text. Then, remove the underscore. Observe that the renderer corrupts in this direction as well:

| Step 2 (alt) | Step 3 (alt)
|--|--
| ![remove-s2](https://user-images.githubusercontent.com/156867/95698378-a96b9000-0c39-11eb-8a79-37c1aad78926.png) | ![remove-s3](https://user-images.githubusercontent.com/156867/95698377-a8d2f980-0c39-11eb-852c-40aa3c840c8e.png)

* MacBook Pro (Retina)
* macOS 10.15.6
* Simplenote 2.2

Contributor guide

Open the contributing guide

Research direction

Reproduce the Markdown rendering issue in a new note on Simplenote for macOS using the supplied text, first adding and then removing the trailing underscore. Start by locating the macOS note-rendering entry point, then verify that editing no longer corrupts the display and that switching notes is not required to restore normal rendering.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.