Automattic / Automattic/simplenote-macos

Project: Advanced Search

Open
#626 3 comments 0 reactions 0 assignees View on GitHub
[feature] search
Dominant language
Swift
Stars
1.6k
Forks
172
Avg merge
11h 17m
Merged PRs (30d)
3

Description

Projected Completion 02/22/2021

### Dependencies
- [x] Integrate SimplenoteFoundation #652
- [x] Integrate SimplenoteSearch #651
- [x] Initialize ViewControllers programatically: Simplenote Storyboard! #660
- [x] Initialize CoreData before ViewControllers #751
- [x] Implement New List Sort Options #755
- [x] Implement ResultsController <> NSTableView Bridge [#6](https://github.com/Automattic/SimplenoteFoundation-Swift/pull/6)

### Task: Business Layer
- [x] Keywords containing `tag:xxx` should filter notes containing such tag #651
- [x] Search should be global! #760
- [x] Implement NoteListController #760 #763 #764 #765 #766 #780 #781

### Task: Notes List
- [x] Replace **NSArrayController > NSFetchedResultsController** #764
- [x] Support realtime updates (IDLE / Searching) #764
- [x] Updating Search Keywords should always scroll to the top of the table #764
- [x] Automatically display `Notes List` whenever the user clicks over the Search Bar (and the list is collapsed) #770
- [x] List: Title in Search Mode / Check with Sly
- [x] List: Bottom Padding #791
- [x] Empty States: **No Results** / **No Notes** #792
- [x] Contextual Results Snippet #830

### Task: Note Editor
- [x] Highlight Search Keywords #835

### Task: SortBar
- [x] Pressing the Sort Bar should display a dropdown with every available option #789
- [x] SortBar should be dismissed when the Search Mode is exited #789
- [x] Note List should display the date relevant to the selected Sort Mode, when appropriate #790
- [x] SortBar should be visible all the time #831
- [x] Divider between SortBar and Notes List #833
- [x] Drop SortBar #850

### Task: Tag Suggestions
- [ ] Display Tags that match with a given keyword below the Search Bar #875
- [ ] Limit the number of Tags to 5 entries #875
- [ ] Pressing over Tag Rows should append `tag:` to the search keyword

### Task: Search Bar
- [x] Relocate the Search Bar above the Notes List #838
- [x] Adjust Sort Bar Style #839
- [x] Bug: Double Click over the Search Bar causes the Window to expand #841
- [x] New SearchBar Style #851

### Task: Minimap
- [x] Highlight Keyword Matches in the main note #835
- [x] Display a Minimap on the right hand side #836

[iOS Sibling Here](https://github.com/Automattic/simplenote-ios/issues/507)

### Mockups

Contributor guide

Open the contributing guide

Research direction

Begin with the unchecked Tag Suggestions items and inspect issue #875 plus the linked iOS sibling for intended behavior. Done means matching tags appear below the Search Bar, no more than five are shown, and selecting a tag appends `tag:` to the query; verify against the provided mockups.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
desktop, search
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.