Automattic / Automattic/simplenote-macos

Searches with hyphens don't highlight search term in note

Open
#1,040 1 comment 0 reactions 0 assignees View on GitHub
[feature] search bug
Dominant language
Swift
Stars
1.6k
Forks
172
Avg merge
11h 17m
Merged PRs (30d)
3

Description

Same issue as https://github.com/Automattic/simplenote-ios/issues/293, when you search for a hyphenated word Simplenote does not highlight the term.

### Expected
To see the full term highlighted.

### Observed
Note with the term appears on search results but searched content isn't highlighted on the list of results nor in the note content.

### Reproduced
1. Add a hyphenated word or phone number into a note (for instance, `follow-up`)
2. Search for a part of that word or phone number with the hyphen (i.e., `follow-`) or the entire string (`follow-up`)

Currently using Simplenote 2.15.1

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in a note containing a hyphenated word or phone number, then search for a partial or complete hyphenated term. Check highlighting in both the search-results list and note content; done means the full searched term is highlighted in both places.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
desktop, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.