Automattic / Automattic/simplenote-ios

Collaborators: Safe Area guidelines are not respected

Open
#937 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Swift
Stars
2.2k
Forks
297
Avg merge
13h 25m
Merged PRs (30d)
6

Description

On Collaborators screen "Add a new collaborator" row doesn't respect safe area guidelines.

### Expected
Safe area guidelines are respected.

### Observed
Safe area guidelines are not respected.

### Reproduced (on an iPhone with a notch)
1. Open a note
2. Open Options screen
3. Open Collaborators screen
4. Rotate into landscape
4. Observe that "Add a new collaborator" row doesn't respect safe area guidelines

Screenshot 2020-10-20 at 16 11 25

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue on an iPhone with a notch by opening a note, navigating through Options to Collaborators, and rotating to landscape. Locate the Collaborators screen and inspect the “Add a new collaborator” row; done means the row respects the safe area in landscape.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.