Automattic / Automattic/simplenote-ios

Searches with Hyphens Don't Highlight Search Term in Note

Open
#293 7 comments 0 reactions 0 assignees View on GitHub
[feature] search [priority] low bug
Dominant language
Swift
Stars
2.2k
Forks
297
Avg merge
13h 25m
Merged PRs (30d)
6

Description

#### Steps to reproduce
1. Add a hyphenated word or phone number into a note (for instance, `bonus-content`)
2. Search for a part of that word or phone number with the hyphen (i.e., `bonus-`), or the entire string (`bonus-content`)

#### What I expected
Like searching for other text in a note, the search would show the content highlighted in the note

#### What happened instead
Note appears in search results, but content that I searched for isn't highlighted in the note when I open it from the results list

#### Simplenote version
4.7.0

#### iOS version
12.2

Initially reported in #1909776-zen

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue in the iOS app using searches such as `bonus-` and `bonus-content` against notes containing hyphenated text. Trace how search results open a note and how the queried text is highlighted. Done means hyphenated words and phone numbers are highlighted consistently when opened from search results.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile-dev, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.