Automattic / Automattic/simplenote-ios

Is the delete button in the iPad passcode screen out of place?

Open
#1,145 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
2.1k
Forks
297
Avg merge
13h 25m
Merged PRs (30d)
6

Description

While working on the screenshots, I noticed the "Delete" button is inline with the number buttons on the iPad as well as the iPhone. To me, on the iPad the button looks a bit out of place like that. I'd expect it either aligned with the center or all the way to the right.

Is this intentional or a tiny Auto Layout constraint detail that needs tweaking?

iPad Pro (12 9-inch) (3rd generation)-06

cc @SylvesterWilmott

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the iPad passcode screen and inspect how the Delete button is constrained relative to the number buttons. Compare the current iPad layout with the attached screenshot and clarify whether it should be centered or right-aligned. Done means the intended iPad alignment is agreed and the layout is updated without disrupting the iPhone arrangement.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
design, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.