Automattic / Automattic/simplenote-electron

`make` `build-if-not-exists` and `build-if-changed` always build

Open
#3,211 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

That's because they look for `dist/app.js` but webpack uses `fullhash` in the name, i.e. `dist/app.20fd562f4b5b27e29042.js`

https://github.com/Automattic/simplenote-electron/blob/f5d463f7a5f5beb3638696c9700b1c7781448744/Makefile#L21

https://github.com/Automattic/simplenote-electron/blob/f5d463f7a5f5beb3638696c9700b1c7781448744/webpack.config.js#L23

Contributor guide

Open the contributing guide

Research direction

Start with the linked Makefile entry around line 21 and compare its output check with the filename pattern in webpack.config.js around line 23. Run the `build-if-not-exists` and `build-if-changed` targets before and after a build, and confirm they recognize the generated hashed bundle instead of rebuilding every time.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, webpack
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.