Automattic / Automattic/simplenote-electron

Searching of URLs not reflected in sidebar

Open
#3,134 0 comments 0 reactions 0 assignees View on GitHub
[feature] search bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
When searching notes via the sidebar find in the web (app.simplenote), the sidebar filters to the notes with the phrase, and also highlights the first "hit" per note with a few words on either side. When searching for part of a url, I expected to see that url as well.

### Observed
Instead, though the phrase is located in the URL, the sidebar shows only the first line of the document. Note that this url is in < and >; without these markdown formatters, the URL is displayed as expected.

### Reproduced
1. In a note with some text of any kind, add a link with a unique URL; I tested with this:
2. With the url still on the screen, start to type "raising-" in the "Search all notes..." box in the sidebar.
3. Watch as the URL is correctly "blue highlighted" (and even the lovable scroll bar notation, but the sidebar display just shows the first line of the doc.
4. Remove the markdown < and >. Suddenly, the URL is just text, and Search works as expected.

This may be as expected: perhaps <> are used to hide the URL and instead display text in it's place, so the sidebar doesn't know what to show here... but without "click here" text, I'd expect to see the URL.

### Where did you see the bug

Windows 10, app.simplenote.com, Chrome Version 109.0.5414.120 (Official Build) (64-bit)

Contributor guide

Open the contributing guide

Research direction

Start in the app.simplenote.com sidebar search flow and reproduce the issue with a URL enclosed in angle brackets, using the "Search all notes..." entry point. Compare the sidebar result with the same URL entered without markdown angle brackets; done means the matching URL is shown or highlighted in the sidebar result.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.