Automattic / Automattic/simplenote-electron
The character ' in a link keeps our link detection from working
- Dominant language
- TypeScript
- Stars
- 5.3k
- Forks
- 588
- Avg merge
- 9h 45m
- Merged PRs (30d)
- 4
Description
### Expected
I would expect that the entirety of a link would be included in link detection
### Observed
Links that contain the character ' are broken up in our link detection
### Reproduced
Paste a link like this into a note : https://coffeescript.org/#try:for%20i%20in%20%5B1..100%5D%0A%20%20multiple3%20%3D%20(i%20%25%203)%20is%200%0A%20%20multiple5%20%3D%20(i%20%25%205)%20is%200%0A%0A%20%20%23%20Buffer%20output%20in%20string%20to%20avoid%20newline%20from%20console.log()%0A%20%20line%20%3D%20''%0A%0A%20%20line%20%2B%3D%20i%20%20%20%20%20%20%20%20%20if%20not%20(multiple3%20or%20multiple5)%0A%20%20line%20%2B%3D%20'Crackle'%20if%20multiple3%0A%20%20line%20%2B%3D%20'Pop'%20%20%20%20%20if%20multiple5%0A%0A%20%20console.log%20lined
### Where did you see the bug
- System Make: Mac OS
- System Model: Macbook Pro
- OS version: 12.3.1
- Browser : Firefox
- Browser version: 100.0.2
Contributor guide
Research direction
The issue names no source files or tests. Reproduce it by pasting the provided CoffeeScript URL into a note, then locate the link-detection entry point and verify that the entire URL, including its apostrophe, is recognized as one link.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, typescript
- Domain
- desktop, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100