Automattic / Automattic/simplenote-electron
Restoring history doesn't update pinned, markdown and publish status
- Dominant language
- TypeScript
- Stars
- 5.3k
- Forks
- 588
- Avg merge
- 9h 45m
- Merged PRs (30d)
- 4
Description
When restoring history pinned, markdown and publish statuses are not updated.
### Expected
When having pinned, enabled markdown, and published the note as the most recent change, when restoring to a previous point in history I expected the mentioned statuses to be removed/updated.
### Observed
Even when restoring history, the note remained pinned, published, and with markdown enabled.
### Reproduced
1. Create a new note and add some content
2. Pin, enable markdown, and publish the note
3. Restore to a point in history before pinning, enabling markdown, or publishing
4. Notice the pin, markdown and published statuses remain unchanged
https://user-images.githubusercontent.com/3696121/125510653-a19c990c-0fea-4ef5-9381-aa6040c42cc6.mp4
Did the history restoration from the staging web app since the history restoration was not available in the Windows app: https://github.com/Automattic/simplenote-electron/issues/2961
### Where did you see the bug
- OS: Windows 10 20H2
- Browser (if applicable): Google Chrome Version 91.0.4472.114 (Official Build) (x86_64)
- Simplenote app version: Simplenote Electron 2.15.0-beta1
Contributor guide
Research direction
Start by reproducing the restoration flow in the staging web app described in the issue, using a note with pinning, Markdown, and publishing enabled before restoring an earlier history point. Trace how history restoration updates note state and verify that each listed status matches the restored point; the related Windows-app issue is #2961.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, typescript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100