Automattic / Automattic/simplenote-electron

`Oops!` page is shown when `Actions` menu is opened for removed note

Open
#2,926 0 comments 0 reactions 0 assignees View on GitHub
bug crash
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
1. There should be no `Oops!` page when note is deleted forever via other device
2. There should be no possibility to publish/collab on a trashed note

If Electron adopts the behaviour of macOS native app, both issues will be gone. This is: don't stay on the note when it was removed on the other device, but open the note which is next in the list (similar to what happens if the note was deleted via Electron)

Please note that hiding `Actions` on app clickout will not solve the issue, because what is done via native macOS in the video below can be done on a separate device.

### Observed
The `Actions` menu remains open for the trashed note. If the note was deleted forever after that, the `Oops!` page is shown:

https://user-images.githubusercontent.com/73365754/120663549-c8ea4e00-c492-11eb-9910-68e564d17a3c.mov

### Reproduced
1. Electron: Open any note from `All notes` and open the `Actions` menu for this note
3. In the other device/client: Trash the note ~> this is a chance for a separate bug: since `Actions` menu remains open in Electron, user will still be able to publish or start a collab for the trashed note
4. In the other device/client: Delete note forever ~> Electron shows `Oops!` page

### Where did you see the bug
- System Make: MBP 16"
- OS: 11.2.3
- Simplenote app version: 2.13.0-beta1

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the cross-device deletion flow in the Electron app: open a note's Actions menu, trash it elsewhere, then delete it forever. Trace the handling of the selected note, the open Actions menu, and the Oops! page. Done means the app leaves a note removed elsewhere, selects the next note, and prevents publishing or collaboration on trashed notes.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.