Automattic / Automattic/simplenote-electron

Undo and Redo stop working after preview mode toggle

Open
#2,914 0 comments 0 reactions 0 assignees View on GitHub
[feature] editor bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

The same is described in #2426 and #2467, and both should have been fixed by #2490. It appears that the case below is still valid.

### Expected
One would assume that undo/redo should still work after going to preview mode and back, especially when seeing `Undo` and `Redo` items enabled in the menu.

### Observed
After activating preview, and then going back, undo/redo stops working.

### Reproduced
1. Create a new note
2. Enter some text gradually. Sth like:
```
One
Two
Three
```
3. Use Undo/Redo to make sure it's works
4. Go to preview mode and back
5. Try using Undo/Redo again ~> it doesn't work

### Where did you see the bug
- OS version: Windows 10 Home via Parallels Desktop | macOS 11.2.3 on MBP 16"
- Simplenote app version: 2.12.0-beta1 Desktop

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the sequence in this issue: edit a new note, use Undo/Redo, toggle preview mode, return, and try Undo/Redo again. Review related issues #2426 and #2467 and the attempted fix in #2490. Done means Undo and Redo still work after returning from preview mode, including when their menu items are enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.