Automattic / Automattic/simplenote-electron

All `#` symbols are hidden in note list for a note, unless it's a `#sometext` (MD enabled)

Open
#2,870 2 comments 0 reactions 0 assignees View on GitHub
[feature] markdown [feature] note list bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
When Markdown is enabled, the hash symbol has to be hidden only in case when it's a header marker. In other words, hash(es) followed by space. Hash should still be shown for cases like:

`Hello, I'm note C#` ~> should be shown as `Hello, I'm note C#`

### Observed
`Hello, I'm note C#` is shown as `Hello, I'm note C`:

Screenshot 2021-04-23 at 16 25 44

Note that hash is shown for cases when it's followed by text with no breaks.

### Reproduced
1. Create a new note
2. Enable Markdown for it
3. Add `Hello, I'm note C#` text
4. Look at the note list ~> it shows `Hello, I'm note C`

### Where did you see the bug

- OS: Windows
- OS version: 10
- Simplenote app version: 2.10.0-beta1

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue using the listed steps with Markdown enabled and `Hello, I'm note C#`. Trace the note-list Markdown handling and verify that header markers followed by spaces are hidden while the hash in `C#` remains visible; the issue is done when the note list shows the complete text.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, markdown, typescript
Domain
desktop, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.