Automattic / Automattic/simplenote-electron
Search matches navigator is not shown if note was in preview mode while searching
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.3k
- Forks
- 589
- Avg merge
- 9h 45m
- Merged PRs (30d)
- 4
Description
Expected
If the note is shown is search, and there are matches within a note, the matches navigator should be shown in both preview and edit modes, momentarily.
Observed
If the note was in preview mode, and search was executed against it, there will be no matches navigator:
Not reproducible on Windows Desktop.
Reproduced
- Have a note with several occurrences of a keyword
- Enable markdown and open preview for the note
- Search for the keyword ~> there will be no search matches navigator at the bottom of the preview.
- Switch to edit and back to preview with 👁 button ~> now the navigator is there
Where did you see the bug
Both desktop app and Chrome under macOS.
- System Model: MBP 16"
- OS version: 11.2.3
- Browser: Chrome Version 90.0.4430.72 (Official Build) (x86_64) + 2.10.0-beta1
- Simplenote app version: 2.10.0-beta1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named in the issue. Start by reproducing the search in a markdown note while preview mode is active on macOS, then trace the preview and search-matches navigator entry points. Done means the matches navigator appears momentarily in preview and edit modes, including immediately after searching from preview mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100