Automattic / Automattic/simplenote-electron

`Cmd` + `Shift` + `Y` shortcut stops working in Search mode

Open
#2,865 0 comments 0 reactions 0 assignees View on GitHub
[feature] editor [feature] search [feature] shortcuts bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
During search, if it's possible to manually move focus to tags input and enter a new tag, it should be possible to jump to tags editing via `Cmd` + `Shift` + `Y` shortcut too.

### Observed
If the note is in search mode, `Cmd` + `Shift` + `Y` shortcut does not jump to tag editor from note editor (but jumps the other way around):

https://user-images.githubusercontent.com/73365754/115454866-ed170600-a229-11eb-8045-30e7ae665c3c.mov

### Reproduced
1. Have a note with some text
2. Enter any text into a search bar, that is also present in the mentioned note
3. Select a note and start editing it ~> it's possible
4. Hit `Cmd` + `Shift` + `Y` ~> focus does not jump to tag input

### Where did you see the bug
- System Make: Parallels Desktop on MBP 16”
- OS: Windows 10 Home 20H2
- Simplenote app version: 2.10.0-beta1

Contributor guide

Open the contributing guide

Research direction

Reproduce the search-mode flow described in the issue: select a matching note, enter editing, and press Cmd + Shift + Y. Trace the shortcut handling for note editing, search mode, and the tag input; done means the shortcut focuses tag editing in search mode while the existing reverse direction still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop, frontend, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.