Automattic / Automattic/simplenote-electron

When keyboard shortcuts are disabled, some still continue to work

Open
#2,864 1 comment 0 reactions 0 assignees View on GitHub
[feature] shortcuts bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
When `Keyboard Shortcuts` are disabled in `Settings` ~> `Tools`, one might assume that shortcuts listed in the shortcuts list should not work.

### Observed
Some part of shortcuts really stops working, e.g.:
- `Cmd` + `Shift` + `P`
- `Cmd` + `/`
- `Cmd` + `Shift` + `U`
- `Cmd` + `Shift` + `K`
- `Cmd` + `Shift` + `J`
- `Cmd` + `Shift` + `Y`
- `Cmd` + `Shift` + `L`

But these still continue to work:

- `Cmd` + `Shift` + `I`
- `Cmd` + `comma`
- `Cmd` + `P`
- `Cmd` + `Shift` + `C`
- `Cmd` + `/`
- `Cmd` + `Shift` + `F`
- `Cmd` + `Shift` + `S`
- `Cmd` + `Shift` + `E`
- `Cmd` + `G`
- `Cmd` + `Shift` + `G`
- Font size manipulations

### Reproduced
1. Open `Settings` ~> `Tools` and disable shortcuts
2. Try using the shortcuts from the list above

### Where did you see the bug
- System Make: Parallels Desktop on MBP 16”
- OS: Windows 10 Home 20H2
- Simplenote app version: 2.10.0-beta1

Contributor guide

Open the contributing guide

Research direction

Start in Settings > Tools with Keyboard Shortcuts disabled and reproduce the listed shortcuts on Simplenote 2.10.0-beta1. Trace the shortcut handling for the shortcuts that still work and verify that every shortcut in the list is disabled when the setting is off.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.