Automattic / Automattic/simplenote-electron

Closing new note info panel when clicking out

Open
#2,857 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### What
The new note info panel is a great improvement, but since it's located far from the button that opens it, closing the popup takes quite a lot of time (hitting `Esc` or moving the cursor to the middle of the screen):

Screenshot 2021-04-20 at 12 51 45

### Why
Currently, it takes too long to close it when using the pointer only.

### How
1. Make it be closed when clicking outside the dialog (should we still keep the `[x]` button and the `Document` header in that case?)
or
2. Show the pop-up right next to the info button (something similar is done on macOS)

Side note / nitpick: the `Document` word in the title of popup looks a bit out of place (to me). Maybe, it's better to have `Information` written there 🤔. We use `Information` in macOS and `Document` on iPadOS. On Android and iOS the popup has no title.

Contributor guide

Open the contributing guide

Research direction

Start by locating the new note information panel and its current close handling in the desktop app. Compare closing on an outside click with positioning the popup beside the info button, then check the existing title and close controls; done means pointer-only users can dismiss the panel quickly without breaking the current controls.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.