Automattic / Automattic/simplenote-electron

Checklist is inserted at wrong position if line starts from a bullet list marker

Open
#2,780 0 comments 0 reactions 0 assignees View on GitHub
[feature] checklist [feature] editor bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
`Insert checklist` should insert the checkbox at the beginning of the line (this is so in iOS, Android, macOS). E.g. have:

`+Plus` ~> user clicks `Insert checklist` ~> result is `☐ +Plus`

### Observed
`+Plus` ~> user clicks `Insert checklist` ~> result is `+- [ ] Plus`

https://user-images.githubusercontent.com/73365754/111340048-efad9b00-8680-11eb-8a8b-f3f163449775.mov

### Reproduced
1. Create a note that contains a line that starts with `-`, `+` or `*`. E.g. `*Hello*`
2. Select this line and insert checklist ~> the result will be `*- [ ] Hello*`

### Where did you see the bug
Video recorded on macOS but the same for example on:
- System Model: Parallels Desktop on MBP 16"
- OS: Windows
- OS version: 10 Home 20H2 build 19042.508
- Simplenote app version: 2.8.0-beta2 desktop

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue from the listed steps in the Simplenote desktop app, then trace the Insert checklist command and its handling of lines beginning with -, +, or *. Done means the checkbox is inserted before the marker while preserving the existing text, with regression coverage for all three markers.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.