Automattic / Automattic/simplenote-electron

Internal links to imported notes can be multiline

Open
#2,768 1 comment 1 reaction 0 assignees View on GitHub
[feature] editor bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
Internal link should not include line breaks

### Observed
Found thanks to [this bug ](https://github.com/Automattic/simplenote-electron/issues/2646). The exported notes have extra line breaks. Once these notes are imported again, the internal link for the note will include the line break:

Screenshot 2021-03-15 at 11 40 27

### Reproduced
1. Have one note with a single line break between title and content
2. Export it
3. Import it back (no matter if json or plain text)
4. In the other note, type `[` and the note title ~> you will see new line symbols shown in the popup
5. Once entered, the internal link will be placed on multiple lines, and will not be handled correctly in MD view.

Screenshot 2021-03-15 at 11 40 39

### Where did you see the bug
- System Make: Parallels Desktop + MBP 16"
- OS: Windows 10 Home | Ubuntu 20.04 | macOS 11.2.3
- Simplenote app version: 2.8.0-beta2 Desktop

Contributor guide

Open the contributing guide

Research direction

Start by following the reproduction steps for exporting and re-importing a note, then inspect the import/export flow and the internal-link title autocomplete. Done means imported note titles do not show line breaks in the popup, inserted internal links stay on one line, and they render correctly in Markdown view.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.