Automattic / Automattic/simplenote-electron

Creating a new note from Trash via shortcut should be forbidden

Open
#2,743 2 comments 0 reactions 0 assignees View on GitHub
[feature] trash bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
If the `new-note` button is disabled when in `Trash`, the shortcut should not work too (same for menu item).

### Observed
`Ctrl+Shift+I` shortcut will switch the app to weird state: there will be still `Trash` header, but notes will be shown from `All Notes`, and also there will be the `Empty Trash` button:

https://user-images.githubusercontent.com/73365754/110797256-91984680-8281-11eb-9212-ca345c842c82.mov

### Reproduced
1. Open `Trash`
2. Press `Ctrl+Shift+I`

### Where did you see the bug
- System Make: Parallels Desktop on MBP 16"
- System Model: Parallels Desktop on MBP 16"
- OS: Windows
- OS version: 10 Home 20H2 build 19042.508
- Browser (if applicable): x
- Browser version (if applicable): x
- Simplenote app version: 2.8.0-beta2 desktop

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the Ctrl+Shift+I shortcut while viewing Trash, then trace the shortcut and menu action that create a new note. Compare them with the disabled new-note button behavior. Done means both shortcut and menu item are blocked in Trash and the view remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.