Automattic / Automattic/simplenote-electron

Keyboard shortcuts are displayed as "Ctrl" in browser, including on the Mac

Open
#2,549 1 comment 0 reactions 0 assignees View on GitHub
[feature] shortcuts bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

We could test this in a more sophisticated way

https://github.com/Automattic/simplenote-electron/blob/develop/lib/dialogs/keybindings/index.tsx#L43

and

https://github.com/Automattic/simplenote-electron/blob/develop/lib/utils/platform.ts#L4

### Expected
Keybindings should display with Cmd on Mac browsers

### Observed
Keybindings are displayed as Ctrl unless using Mac on Electron

Contributor guide

Open the contributing guide

Research direction

Start by reading lib/dialogs/keybindings/index.tsx around line 43 and lib/utils/platform.ts around line 4 to trace how browser and Electron platforms choose shortcut labels. Verify the behavior in a Mac browser and compare it with Electron; done means keybindings display Cmd on Mac browsers while retaining the observed behavior elsewhere.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.