Automattic / Automattic/simplenote-electron

JSON import: Validate structure of JSON file

Open
#2,517 1 comment 0 reactions 0 assignees View on GitHub
[feature] import bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

Follow-up task from https://github.com/Automattic/simplenote-electron/pull/2446

See https://github.com/Automattic/simplenote-electron/pull/2446#discussion_r519026400

### Expected
Importing a JSON file that isn't a Simplenote export returns an errror.

### Observed
It crashes instead.

### Reproduced
1. Find a random .json file (not a Simplenote export)
2. Try to import it

Contributor guide

Open the contributing guide

Research direction

Start by tracing the JSON import path described in the reproduction and compare it with the Simplenote export structure discussed in pull request #2446 and its linked review discussion. Done means a random non-Simplenote JSON file returns an error during import instead of crashing.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.