Automattic / Automattic/simplenote-electron

Electron: Context menu shows Paste in preview mode

Open
#2,408 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
Menu only offers Paste when an editable text area was clicked on

Did some research, it's because of this: https://github.com/Automattic/simplenote-electron/blob/fc8921291b6b702db35b076d65e4632203ff4574/desktop/context-menu/index.js#L36

Originally reported over here https://github.com/Automattic/simplenote-electron/issues/1893#issuecomment-703502540

### Observed
Whenever the default Electron menu is shown, Paste is available. This happens if you right-click on the note list, the editor in preview mode, or other parts of the app.

Screen Shot 2020-10-01 at 9 41 14 AM

Contributor guide

Open the contributing guide

Research direction

Start in desktop/context-menu/index.js at the referenced line that causes the default Electron menu to appear, then reproduce the menu on the note list, preview-mode editor, and other non-editable areas. Done means Paste is offered only after clicking an editable text area, while the reported contexts no longer show it.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, javascript
Domain
desktop, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.