Automattic / Automattic/simplenote-electron

On Russian keyboards, "Б" character adds a tag

Open
#2,040 15 comments 0 reactions 0 assignees View on GitHub
[feature] shortcuts bug i18n keyboard
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
We should split on commas regardless of keyboard layout

### Observed
On Russian keyboards, the "Б" character is apparently the same keycode as the comma on English keyboards so typing it causes a tag to be added.

It's possible this also implies that comma doesn't work to add a tag for Russian keyboards (since it would be a different keycode). I haven't tested that scenario.

User reported in 2896068-zen and reproduced it in Windows 10 and on web.

Contributor guide

Open the contributing guide

Research direction

No file or test is named in the issue. Start by locating the tag-input keyboard handler and reproduce the behavior on Windows 10 with a Russian keyboard layout; done means commas add tags regardless of layout and typing Б does not add a tag.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.